[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: "svn revert" performance

From: <kfogel_at_collab.net>
Date: 2003-10-31 15:09:42 CET

"C. Michael Pilato" <cmpilato@collab.net> writes:
> We do sleep once per revert operation, but because you ran revert
> using wildcards, each target (each expanded wildcard result) is its
> own revert operation. Had you simply run 'svn revert -R .', you would
> have only slept once.

Huh, that seems wrong. We ought to sleep once at the end of the
overall operation, whether or not there were multiple targets.

> It's too much of a burden to expect the individual client programs to
> remember to sleep() for their own safety. That's why we do this down
> in the core libraries. And it would be an API atrocity to add some
> idiotic callback from those libraries to ask the question "Can I sleep
> now?".

Oh. And now I understand the reason for the lossage :-).

> So it would seem that the best way to get the behavior you want is to
> passing the whole target array to the core libraries and iterated over
> them there instead of in the client program itself. I'm fine with
> such an API change. Got patch?

That would fix it, yep.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 31 15:49:11 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.