Re: APR_POOL_DEBUG: minor bug

Sander Striker wrote:
>>From: Julian Foad [mailto:julianfoad@btopenworld.com]
>>Sent: Wednesday, October 29, 2003 11:12 PM
>
>>In apr/include/apr_pools.h:
...
>>I think the following is one correct solution:
>>
>>#if (APR_POOL_DEBUG - APR_POOL_DEBUG - 1) == +1
>>/* If APR_POOL_DEBUG is blank, we get +1; if it is a number, we get -1. */
>
> Makes sense. This is really for the dev@apr list,

Yes - sorry.

> I'll pick it up and apply
> it though. Thanks for the patch.

Thanks.

>>(Of course there is a simple way to work around the bug: just use
>> #define APR_POOL_DEBUG=1

(oops: without the "=")

>>instead of
>> #define APR_POOL_DEBUG
>>)
>
> Yes, but this preprocessor magic was put in place so that people could do:
>
> CPPFLAGS=-DAPR_POOL_DEBUG make
>
> without being confronted with the fact that they should have used
> -DAPR_POOL_DEBUG=1

Sure.

> Note that the usage of ./configure --enable-pool-debug=... is encouraged.

Yes. That works anyway, because it sets APR_POOL_DEBUG to "1" explicitly.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 30 13:44:20 2003