Re: svn commit: rev 7565 - in trunk/subversion: include libsvn_wc tests/clients/cmdline

Philip Martin wrote:
> philip@tigris.org writes:
>
>>Add a mechanism that "repairs" the text-time and prop-time in the
>>entries file if they differ from the time of the working copy files
>>even though there are no text/property differences. This addresses
>>issue 791.
...
> The new "repair" code runs automatically whenever Subversion checks
> for changes while holding a write lock. Ideally one would be able to
> trigger the repair of an entire working copy, at present I know of two
> ways to ways to do it:
>
> 1) run "svn revert --recursive"
> 2) run "svn commit"
>
> Neither of these is ideal. Using 1) has the obvious disadvantage that
> it destroys any local modifications. Using 2) doesn't require one to
> complete the commit, quitting the log message editor without saving
> and aborting the commit will do the job, but it's hardly the interface
> one would choose.
>
> Do we need a more intuitive interface this repair? There are a number

No, we don't! It's an implementation detail, a performance optimisation, like caching. Why should the user need to even know that it exists, let alone have a command for activating it?

I suspect that it is only because you know what's going on under the hood that you feel the need to make Subversion clean it up.

> of things we could do: 1) add a new option to "svn status" to cause it
> to take a write lock, 2) make "svn cleanup" run the check for changes
> on every entry, 3) add a new "svn repair" command, etc. I'm not
> overly keen on any of those, "svn cleanup" is the one I dislike least,
> so I'd choose to leave things as they are. Thoughts?

+0 on "cleanup" doing it, as "cleanup" is already an "under the hood" command for "un-breaking" Subversion. Cleaning up the entries time stamps is a reasonable thing for it to do.

-1 on any other user interface for activating the clean-up.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 30 12:44:38 2003