Ah. Fair enough. +1
On Wed, Oct 29, 2003 at 01:57:59AM -0500, Russell Yanofsky wrote:
> Greg Stein wrote:
> > On Tue, Oct 28, 2003 at 10:59:12AM -0500, Russell Yanofsky wrote:
> >> Would it be ok for me to commit the following api change?
> >>
> >> Log Message:
> >>
> >> Minor api change to allow the libsvn_subr library to be built as a
> >> dll.
> >>
> >> * subversion/include/svn_md5.h
> >> * libsvn_subr/md5.c
> >> (svn_md5_empty_string_digest):
> >> convert this from an extern global into a function that can be
> >> exported by extractor.py
> >
> > Can't you just have extractor.py recognize that one case?
>
> If extractor.py was changed to export this, we would still need to add a
> declspec(_dllimport) to the header so it could actually be used.
> declspec(__dllimport) is optional for imported functions, but not for
> imported data.
>
> > I'd rather
> > not switch this to a global if we can just special-case this in the
> > .def file.
>
> I'm not switching to a global, I'm switching svn_md5_empty_string_digest
> *from* a global variable to a normal api function.
>
> > IOW, you're special-casing via functions, or via .def. I think the
> > latter is probably nicer :-)
>
> This is the only global variable in the entire subversion API. By converting
> it to a function I'm eliminating a special case, not creating one.
>
> - Russ
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 29 08:40:44 2003