Revision 2 [was Re: [PATCH] Fix for Issue #1093 (pre-release)]

On Tue, 28 Oct 2003, Shlomi Fish wrote:

>
> svn diff does not trace through file moves or copies.
>
> This patch hopefully fixes this problem. It is not ready for prime time
> yet, and I'm just posting it here to get some comments.
>
> Things to do:
>
> 1. Add comments.
>
> 2. Add some regression tests.
>

I forgot to add that it should pass the tests. In any case, this version
of the patch does pass all tests. The log is (just for you kfogel):

<<<
Resolves Issue #1093 (svn diff does not follow moves or copies)

* libsvn_repos/delta.c:
  Added the get_node_id_with_history function that attempts to extract
  information about the node from the two root FS's and its path.

  (svn_repos_dir_delta): converted to use get_node_id_with_history. After
  its use, it uses the returned parameters (active_*) instead of the
  original ones.
>>>

To do:

1. Clean up the code. (rename get_node_id for instance, remove #if 0)

2. Add comments.

3. Add regression tests.

4. Update the log message in accordance to 1-3.

cmpilato, do you believe this patch does not break anything?

Regards,

        Shlomi Fish

----------------------------------------------------------------------
Shlomi Fish shlomif@vipe.technion.ac.il
Home Page: http://t2.technion.ac.il/~shlomif/

An apple a day will keep a doctor away. Two apples a day will keep two
doctors away.

        Falk Fish

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org