[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: --rev-prop or --revprop?

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2003-10-28 04:59:21 CET

kfogel@collab.net wrote:
> Julian Foad <julianfoad@btopenworld.com> writes:
>
>>Should I leave "--revprop" as a synonym for "--rev-prop" for the
>>time being? I probably should, because scripts like
>>propchange-email.pl will need to be updated accordingly. (I can
>>update the master copy in the source tree, but not the copy running
>>on tigris.org.)
>
> I think the only thing that would prompt them to change would be the
> removal of support for the old option, but do as you think best.

I've just split my patch into two: the change, and the backwards-compatible transition feature, so it will be easy to revert just that part of it later. But...

>>Grepping through, the other related thing is the name
>>"{pre,post}-revprop-change"; should I put the extra hyphen in there
>>too? Perhaps not.
>>
>>Or should I forget the whole idea? I've written and tested the
>>patch (including keeping "--revprop" as an obolete synonym), so can
>>commit easily if you're still happy with the idea.
>
> I would be harsh to change the hook scripts' names. Then people's
> repositories will start doing unexpected things, which is more serious
> than clients doing unexpected things. On other hand, one hates to go
> to 1.0 with a name that people don't like. So I guess we'd ideally
> have code that looks first for 'pre-rev-prop-change', then for
> 'pre-revprop-change' if the first fails... Heh heh <evil grin>

Yes, more work for me, as I suspected.

> I like the consistency and intuitiveness of "--revprop", because it
> treats 'revprop' as a single compound noun.

You mean a compound noun as in "dry-run" or "diff-cmd" or "config-dir"? :-)

> Others find this neither
> consistent nor intuitive. These people are clearly out of their
> heads, but I can't prove it :-).

They may be out of their heads, but there are lots of them.

> So, paint the bikeshed any color you please.

Well, we have a rough consensus: no more people want it to change than want it to stay the same, so it stays as it is.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 28 04:58:21 2003

This is an archived mail posted to the Subversion Dev mailing list.