Philip Martin <philip@codematters.co.uk> writes:
> Philip Martin <philip@codematters.co.uk> writes:
>
> > Yikes! Is that a bug in the libsvn_fs node cache?
>
> Hmm, dag_node_cache_get returns a pointer to the cached node, the
> lifetime of that node depends on how soon the cache entry gets reused.
> I think dag_node_cache_get needs to accept a pool parameter and call
> svn_fs__dag_dup() and so return a pointer to a node with a defined
> lifetime.
See my other post. The suggestion you're making here was my first
answer, which I then trashed in favor of advocating a simpler a
system. However, this solution is a much easier fix, and allows us to
cache the maximum amount of information (which is good). I'm
technically not supposed to be coding today (uh oh, here comes the
wife :-) , but you have my +1 if you wish to make this change.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Oct 26 17:40:16 2003