[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 7513 - trunk/subversion/clients/cmdline

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2003-10-25 02:33:16 CEST

bliss@tigris.org writes:

> Author: bliss
> Date: Fri Oct 24 11:25:18 2003
> New Revision: 7513

> Modified: trunk/subversion/clients/cmdline/log-cmd.c
> ==============================================================================
> --- trunk/subversion/clients/cmdline/log-cmd.c (original)
> +++ trunk/subversion/clients/cmdline/log-cmd.c Fri Oct 24 11:25:18 2003

> @@ -192,7 +196,8 @@
>
> if (rev == 0)
> {
> - printf ("No commit for revision 0.\n");
> + svn_stream_printf (lb->out, pool,
> + "No commit for revision 0." APR_EOL_STR);

         SVN_ERR (svn_stream_printf (...));

I know the printf was unchecked, but I see no reason not to catch the
errors. If you ever do want to throw away an error use

        svn_error_clear (svn_stream_printf (...));

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 25 02:33:52 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.