[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 7508 - trunk/subversion/libsvn_client

From: Greg Stein <gstein_at_lyra.org>
Date: 2003-10-24 23:58:00 CEST

On Fri, Oct 24, 2003 at 07:00:32AM -0400, mark benedetto king wrote:
> On Fri, Oct 24, 2003 at 02:16:39AM -0700, Greg Stein wrote:
> >
> > Re: rearrange... Nah... the current code is nice and clean. Thanks.
> >
> It's so clean now that the break could become a return, and the
> conditional below made unconditional.

Actually, I think it needs to change. Looking again at the code, it seems
like if two changes are in there, both a changed_path but not a "child",
then you could exit the loop with changed not NULL and
changed->changed_path not NULL.

I don't know if that is possible or makes sense in this context, but the
switch to a return would satisfy my "dunno question" (which others might
have, looking at that code, too).


Greg Stein, http://www.lyra.org/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 25 00:03:55 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.