[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issue: Extra log CRs under Windows

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2003-10-24 15:55:01 CEST

Tobias Ringstrom <tobias@ringstrom.mine.nu> writes:

> Masaru Tsuchiyama wrote:
> >>>>Put simply: 'svn log' under Windows ends most lines with
> >>>>CR-CR-LF.
> I did some investigation, and the reason is that log_message_receiver
> insubversion/clients/cmdline/log-cmd.c uses printf to print a string
> that already has been translated by svn_subst_detranslate_string to
> use CR-NL. When printf prints that string, the NL will be translated
> to CR-NL again, and you get CR-CR-NL.
> Actually most users of svn_subst_detranslate_string uses printf, so I
> think the right solution is to remove the EOL translation from
> it. That would also make translate/detranslate each others inverse.
> Unless someone complains, I'll perform that change.

I'm not convinced that that would be a correct change. Seems like it
would be more accurate to use a binary output stream instead of going
through printf() for those places that are printing multi-lined,
detranslated strings. Also, svn_subst_detranslate_string() doesn't
repair the line-endings in (and will throw an error on) a
mixed-line-ending string. Removing this behavior and using printf()
will simply mask what might be an interesting problem with the string.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 24 15:56:42 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.