Re: svn commit: rev 7508 - trunk/subversion/libsvn_client

Greg Stein <gstein@lyra.org> writes:

> On Thu, Oct 23, 2003 at 04:43:50PM -0500, cmpilato@tigris.org wrote:
> >...
> > +++ trunk/subversion/libsvn_client/blame.c Thu Oct 23 16:43:49 2003
> >...
> > - if (strncmp (path, lmb->path, len) == 0 && lmb->path[len] == '/')
> > - break;
> > + if ((strncmp (key, lmb->path, klen) == 0)
> > + && (lmb->path[klen] == '/')
> > + && (change->copyfrom_path))
> > + {
> > + lmb->path = svn_path_join (change->copyfrom_path,
> > + lmb->path + klen + 1,
> > + lmb->pool);
> > + break;
> > + }
>
> You've changed the logic here. Now, it will only 'break' when a
> copyfrom_path is present. Before, it would break out regardless.
>
> Not sure if that matters from a logical standpoing, but it costs a bit of
> extra time.

Yeah, it does cost time, but only in an errorful case. I can
re-arrange it if you'd like.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 24 02:50:59 2003