Re: svn commit: rev 7502 - trunk/subversion/libsvn_subr

On Thu, Oct 23, 2003 at 12:41:23PM -0500, ghudson@tigris.org wrote:
> Author: ghudson
> Date: Thu Oct 23 12:41:22 2003
> New Revision: 7502
>
> Modified:
> trunk/subversion/libsvn_subr/subst.c
> Log:
> Speed up keyword translation.

Excellent.

>...
> +++ trunk/subversion/libsvn_subr/subst.c Thu Oct 23 12:41:22 2003
> @@ -542,9 +542,8 @@
> const svn_subst_keywords_t *keywords,
> svn_boolean_t expand)
> {
> - svn_error_t *err = SVN_NO_ERROR;
> - svn_error_t *read_err, *close_err;
> - char c;
> + char buf[SVN_STREAM_CHUNK_SIZE + 1];

Modern machines are nice, but 100k on the stack? That seems just a tad
overboard :-)

I'd suggest something like 4k.

>...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org