RFC: (Issue 1213) svn cmd -r PREVn:HEAD <file>

Hello, all!

I was just looking at issue 1213 and the patches that were submitted.

Here is my $0.03:

1. PREVn should be defined as 'n' revisions before COMMITTED. PREV and
PREV1 therefore being the same.

2. The current PREV just takes COMMITED-1, which HAPPENS to get the
previous, but, say in a diff command, the revision number is COMMITTED-1,
not PREV. Sometimes it's nice to know EXACTLY what you are diffing.

THEREFORE...

I propose that PREVn always contacts the repository to get the actual
revision numbers. Could this be done by grabbing the log revisions? Or
would that be too much overhead?

Would we want to re-do all the svn_opt_revision_previous, or add a new type,
and keep the default of assuming PREV == COMMITTED-1? OR... if we are
getting exact revision numbers, set the type to svn_opt_revision_number?

I'm thinking that we could do almost all of this in libsvn_subr/opt.c

If we're doing PREV or PREVn, we still must contact the repository ANYWAY
for the operation we are doing, so why not do the Right Thing(tm) and get
the real revision numers?

Comments? Questions? Flames? Suggestions?

-Richard Balint

-----
Sir.Woody_at_Hackswell.com http://sir.woody.hackswell.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 22 19:39:55 2003