Re: svn commit: rev 7466 - trunk/subversion/libsvn_ra_dav

Greg Stein <gstein@lyra.org> writes:
> Hmm. Where do you suppose *statstruct is allocated? Do you ever free it? I
> don't see anything freeing this. Hunh...
>
> Kind of suspicious here, don't you think? :-)

Great review (below) ... But the above is a weird question, given a
pool-based system :-).

> > ne_xml_destroy(error_parser);
> >
> > /* If the status code was one of the two that we expected, then go
> > ahead and return now. IGNORE any marshalled error. */
> > - if (rv == NE_OK && (*code == okay_1 || *code == okay_2))
> > + if (rv == NE_OK
> > + && (statstruct->code == okay_1 || statstruct->code == okay_2))
> > return SVN_NO_ERROR;
>
> Oh. Um. Maybe not so good.

Beautiful catch! Fixed in r7478, thanks.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 22 17:23:22 2003