Greg Stein <gstein@lyra.org> writes:
> On Tue, Oct 21, 2003 at 04:05:29PM -0500, kfogel@tigris.org wrote:
> >...
> > +++ trunk/subversion/libsvn_ra_dav/fetch.c Tue Oct 21 16:05:28 2003
> > @@ -2042,6 +2042,9 @@
> > const char *vcc;
> > int http_status;
> >
> > + SVN_ERR (svn_ra_dav__get_vcc
> > + (&vcc, rb->ras->sess, rb->ras->url, rb->ras->pool));
> >...
> > - err = svn_ra_dav__get_vcc(&vcc, rb->ras->sess, rb->ras->url, rb->ras->pool);
> > - if (err)
> > - {
> > - (void) apr_file_close(rb->tmpfile);
> > - return err;
> > - }
>
> Previously, a failure in getting the VCC would close the file. You altered
> the behavior here -- it doesn't close that file before throwing an error.
Oh, poo. I'll take a large degree of blame for that, since making
this part of the change was my idea. I saw that we were moving this
call to a place prior to our use of the tmpfile, forgetting that while
we weren't yet writing to the tmpfile, it had still already been
created.
Will fix.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 22 15:16:47 2003