"Fletcher, Duncan" <Duncan.Fletcher@dsto.defence.gov.au> writes:
> Reproduction recipe:
>
> svn co http://path/to/some/repository A
> svn propset svn:externals ". http://path/to/some/other/repository" A
> svn status A
>
> Now, wait a moment and watch the infinite loop roll by :)
Ah. I *thought* svn:externals disallowed "." as the target directory,
in other words, it should fail when you do the propset... Nope, heh,
almost:
----------------------------------------------------------------------
rev 6639: kfogel | Fri, 01 Aug 2003 | 10 lines
Resolve issue #1449: Don't allow svn:externals to specify '..' in the
target directory.
* subversion/libsvn_client/externals.c
(parse_externals_description): Check for '..', error if find it.
* subversion/tests/clients/cmdline/externals_tests.py
(disallow_parent_directory_reference): New test.
(test_list): Run it.
----------------------------------------------------------------------
We need to do the same thing for ".", since the system won't work if
the target is ".". Also, the above change didn't protect at propset
time either, so really there's some cleanup left to do for ".." as
well.
I'll take care of it, thanks for the post.
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 17 23:24:22 2003