API: svn_client_log

I wanted to prevent svn from allowing "svn log" with multiple local targets, because that doesn't work properly and is not easy to fix. I realised that the interface to svn_client_log is very wooly.

svn_client_log apparently takes a list of "targets". However, it doesn't really want a list of "targets", it wants either:

* a URL followed by a list of suffixes for that URL; or

* a list of local WC paths (actually, let's restrict this to just one path for the time being, because it doesn't work with more than one). WC paths do not necessarily all connect to the same repository, so we need to specify what happens in that case.

If now is the time to check the APIs, I'd say this one is a prime candidate for being fixed. The idea of the form of the first argument determining the meaning of all the arguments is obviously a command-line syntax issue, not suited to GUIs etc.

Can we change it to something like:

  /* base_url must point into a repository. url_suffixes are relative paths to append to base_url; at least one must be given, even if it is the empty suffix. */
  svn_client_log_url (base_url, url_suffixes)

  svn_client_log_path (wc_path) /* We might provide a multiple-paths version one day if we can decide what it should do. */

Or, maybe better, just have the URL version, and leave the client to convert local WC paths into one or more sets of URLs if it wants to.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 15 21:35:40 2003