[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_io_open_unique_file: quadratic cost

From: Tobias Ringstrom <tobias_at_ringstrom.mine.nu>
Date: 2003-10-15 16:32:42 CEST

First of all I think svn uses svn_io_open_unique_file for two slightly
different purposes. The first purpose is to create a semi-nice name that
will be left behind after svn finishes. The second purpose is to create
truly user invisible temporary files.

I think that there should be two different functions for these two
different (but similar) purposes. It is possible that apr_file_mktemp is
the perfect function for the temporary file creation, in which case we
already have all the functions we need.

Some callers of svn_io_open_unique_file should then be changed to use
the new function. One example is svn diff -- especially when diffing two
URLs. Subversion should not fail just because the user does not have
write permission in the currect directory, and it definately should not
have to try to create 1000000 files just to figure that out. The fact
that svn has to create a temporary file should be invisible to the user.

Does that sound sound to you? :-)


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 15 16:33:50 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.