[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Awful first cut of ra_svn password authentication

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2003-10-15 00:55:09 CEST

On Tue, 2003-10-14 at 18:12, Garrett Rooney wrote:
> Returning FALSE as a char *? ick.

Oops, I meant NULL there.

The server doesn't currently have a way of logging errors, so it doesn't
do a whole lot of good to report a failure to open the file.

> And using a FILE* instead of an apr_file_t is kind of odd, most of
> the rest of subversion uses the APR interfaces for this sort of
> thing.

Check out libsvn_subr/config_file.c:svn_config__parse_file().

> Shouldn't there be a patch for svnserve somewhere around here

Looks like I diffed one level too deep by mistake. I'll try again.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Wed Oct 15 00:56:09 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.