Re: Detecting unhandled errors

"Sander Striker" <striker@apache.org> writes:

>> From: cmpilato@localhost.localdomain
>> [mailto:cmpilato@localhost.localdomain]On Behalf Of C. Michael Pilato
>> Sent: Monday, October 13, 2003 3:42 PM
>
> [...]
>> Well, I fully expected things to fail with only the patch I sent. We
>> still don't have any code cleaning up errors we *do* handle. That is,
>> the client should be clearing the error chain after it calls
>> svn_handle_error() (or perhaps svn_handle_error() should remove the
>> deathly pool cleanup functions).
>
> Well, actually, all the cmdline client tests succeed. So apparently it
> isn't that bad.

svn_handle_error doesn't do the right thing

$ svn ls
../svn/subversion/libsvn_wc/lock.c:494: (apr_err=155007)
svn: Path is not a working copy directory
svn: '.' is not a working copy
Aborted

I think this is the "feature" that the regression tests don't detect a
client that aborts. We could do it on Unix but not on Windows, and we
don't want any tests to rely on platform-specific error detection.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org