Re: Catching dangling transactions

Philip Martin <philip@codematters.co.uk> writes:

> Philip Martin <philip@codematters.co.uk> writes:
>
>> Those two updates are not quite the same, after the first update fails
>> the working copy is marked incomplete. When I try it, all obstructed
>> updates in an incomplete working copy leave behind a transaction.
>
> I'm not really an expert in this bit of the code, but the error
> handling at the end of svn_repos_finish_report looks a bit suspect to
> me, if svn_repos_dir_delta returns an error the transactions are not
> removed.

After reading svn_repos.h, it appears to be the callers responsibilty.
In that case the problem is probably in svn_wc_crawl_revisions, all
those SVN_ERRs bypass the abort_report: processing, in this particuar
case the reporter->finish_report call is the culprit.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org