Re: svn commit: rev 7321 - in trunk: . subversion/clients/cmdline subversion/include subversion/libsvn_client subversion/libsvn_subr subversion/libsvn_wc subversion/tests/clients/cmdline subversion/tests/clients/cmdline/svntest

Philip Martin wrote:
> julianfoad@tigris.org writes:
>
>>Added:
>> trunk/subversion/tests/clients/cmdline/autoprop_tests.py
>
> You didn't set svn:eol-style or svn:executable.

Ah - I hadn't thought or noticed. Fixed that, and export_tests.py too which was missing an eol-style.

>>Modified:
>> trunk/build.conf
>> trunk/subversion/clients/cmdline/cl.h
>> trunk/subversion/clients/cmdline/main.c
>> trunk/subversion/include/svn_config.h
>> trunk/subversion/libsvn_client/add.c
>
> You didn't fix this warning
>
> ../svn/subversion/libsvn_client/add.c: In function `auto_props_enumerator':
> ../svn/subversion/libsvn_client/add.c:89: warning: declaration of `value' shadows a parameter
> ../svn/subversion/libsvn_client/add.c:68: warning: shadowed declaration is here
> ../svn/subversion/libsvn_client/add.c:99: warning: assignment discards qualifiers from pointer target type

Ah - I didn't see them scroll by. Fixed those, though not very elegantly (with a cast), and also one in subversion/clients/cmdline/info-cmd.c which was not due to this commit.

Thanks for noticing.

Oh - on trying to commit, I find that they have all been fixed already apart from export_tests.py, which I have fixed in r7347.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 7 23:02:23 2003