[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 7316 - in trunk/subversion: clients/cmdline include libsvn_subr svnlook

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2003-10-07 15:54:17 CEST

cmpilato@tigris.org writes:

> Author: cmpilato
> Date: Mon Oct 6 09:01:35 2003
> New Revision: 7316
>
> Modified:
> trunk/subversion/clients/cmdline/info-cmd.c
> trunk/subversion/clients/cmdline/log-cmd.c
> trunk/subversion/include/svn_time.h
> trunk/subversion/libsvn_subr/subst.c
> trunk/subversion/svnlook/main.c
> Log:
> (Mostly) fix issue #1534: Callers of svn_time_to_human_cstring should
> expect a UTF8 encoded string. This does not handle the need to
> localize the date when substituting keywords into working copy files.
> Patch by Josh Pieper <jpieper@andrew.cmu.edu>.

> Modified: trunk/subversion/clients/cmdline/info-cmd.c
> ==============================================================================
> --- trunk/subversion/clients/cmdline/info-cmd.c (original)
> +++ trunk/subversion/clients/cmdline/info-cmd.c Mon Oct 6 09:01:35 2003
> @@ -39,7 +39,12 @@
> const char *desc,
> apr_pool_t *pool)
> {
> - printf ("%s: %s\n", desc, svn_time_to_human_cstring (atime,pool));
> + const char *time_utf8;
> + const char *time_stdout;
> +
> + time_utf8 = svn_time_to_human_cstring (atime, pool);
> + SVN_ERR (svn_utf_cstring_from_utf8 (&time_stdout, time_utf8, pool));
> + printf ("%s: %s\n", desc, time_stdout);
> }

../svn/subversion/clients/cmdline/info-cmd.c: In function `svn_cl__info_print_time':
../svn/subversion/clients/cmdline/info-cmd.c:46: warning: `return' with a value, in function returning void

Looks like you have to do a bit more work to return the error value.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 7 15:55:07 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.