# Re: Inno Setup & svn pre Beta: Help wanted

From: Jostein Chr. Andersen <jostein_at_josander.net>
Date: 2003-10-06 14:19:28 CEST

On Monday 06 October 2003 13.48, Steve Williams wrote:
> > * Path handling on install/uninstall (Pascal script):
> . . .
> Have you created a svnpath.pas file? I couldn't find one in the
> repos. Or do you need one created?
No, I have not. I don't think I need a new one at the moment (because it
can't run on uninstall). I will use svnpath.exe at the moment and wait
until IS comes with scripting support on uninstall.

However: -I could use a pascal script subroutine that add/removes the
following lines from a httpd.file in the LoadModule section:

The subroutine should be called by something like this (with two
parameters):

sFileName: 'path\\to\\httpd.conf'

The return value bResult are TRUE in success

> I noticed you have committed in the compiled executable for
> svnpath.exe as well as the source for it. I was under the belief that
> anything that could be generated from data in the repository should
> not be committed to the repository. Is that the case?

You are right, it should not be committed and I will not do it again.
The only thing that should be committed is sources.

No one have bashed me on this before (well Branko said it about one year
ago) because I'm probably older and more ugly than most of the people in
this mailing list :-)

Jostein

--
Jostein Chr. Andersen <jostein_at_josander.net> http://www.josander.net/
Public PGP Key:
Key: http://www.josander.net/pub_keys/jostein_josander.net.asc
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org