Re: [PATCH] automatic properties

Martin Furter <mf@rola.ch> writes:

> Index: subversion/libsvn_client/add.c
> ===================================================================
> --- subversion/libsvn_client/add.c (revision 7308)
> +++ subversion/libsvn_client/add.c (working copy)

> +static svn_boolean_t
> +auto_props_enumerator (const char *name,
> + const char *value,
> + void *baton)
> +{
> + auto_props_baton_t *autoprops = baton;
> + char *property;
> + char *last_token;
> + int len;
> +
> + /* nothing to do here without a value */
> + if (strlen (value) == 0)
> + return TRUE;
> +
> + /* check if filename matches and return if it doesn't */
> + if (apr_fnmatch (name, autoprops->filename, 0) == APR_FNM_NOMATCH)
> + return TRUE;
> +
> + /* parse the value */
> + property = apr_pstrdup (autoprops->pool, value);
> + property = apr_strtok (property, ";", &last_token);
> + while (property)
> + {
> + char *value;
> +
> + value = strchr (property, '=');
> + if (value)
> + {
> + *value = 0;
> + value++;
> + apr_collapse_spaces (value, value);
> + }
> + else
> + value = "";

../svn/subversion/libsvn_client/add.c: In function `auto_props_enumerator':
../svn/subversion/libsvn_client/add.c:89: warning: declaration of `value' shadows a parameter
../svn/subversion/libsvn_client/add.c:68: warning: shadowed declaration is here
../svn/subversion/libsvn_client/add.c:99: warning: assignment discards qualifiers from pointer target type

> + apr_collapse_spaces (property, property);
> + len = strlen (property);
> + if (len > 0)
> + {
> + apr_hash_set (autoprops->properties, property, len, value );
> + if (strcmp (property, SVN_PROP_MIME_TYPE) == 0)
> + autoprops->mimetype = value;
> + else if (strcmp (property, SVN_PROP_EXECUTABLE) == 0)
> + autoprops->have_executable = TRUE;
> + }
> + property = apr_strtok (NULL, ";", &last_token);
> + }
> + return TRUE;
> +}

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org