[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 7290 - trunk/subversion/bindings/swig

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2003-10-04 22:17:04 CEST

"Russell Yanofsky" <rey4@columbia.edu> writes:

> > Actually, if someone out there can take a look at this -- I don't see
> > anything wrong, but for some reason my typemap doesn't seem to be
> > "taking". The generated svn_repos.c file doesn't have the typemap
> > applied. I'm probably missing something really obvious. Any
> > thoughts?
> It looks like it could be due to a swig bug in handling function pointer
> arguments. The following change makes the typemap start working work for me:
> Index: subversion/include/svn_repos.h
> ===================================================================
> --- subversion/include/svn_repos.h (revision 7294)
> +++ subversion/include/svn_repos.h (working copy)
> @@ -432,10 +432,10 @@
> * convenience of the implementor, who should not expect it to live
> * longer than a single callback call.
> */
> -typedef svn_error_t *svn_repos_history_func_t (void *baton,
> - const char *path,
> - svn_revnum_t revision,
> - apr_pool_t *pool);
> +typedef svn_error_t *(*svn_repos_history_func_t) (void *baton,
> + const char *path,
> + svn_revnum_t revision,
> + apr_pool_t *pool);

Doh! Please do commit up.

And now, if I could just remember the other callback function that I
copy-n-pasted when I created this one ... A-ha!
svn_wc_relocation_validator! Figures, of all the callbacks, I'd
choose what was probably the only one that didn't conform to the rules
to be my model... Sheesh... Okay, nevermind, I'll fix both of these
and commit the change.

Russell, you're just making my day.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 4 22:18:11 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.