[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn-0.30.0-setup.exe trashing the Environment $path as per 0.14.

From: Branko Čibej <brane_at_xbc.nu>
Date: 2003-10-01 20:43:52 CEST

Jostein Chr. Andersen wrote:

>On Wednesday 01 October 2003 00.04, David Simmons wrote:
>
>
>>My gut feeling is that there was a buffer overflow in the code that
>>updated the registry entry. I.e., the code that updated the path
>>variable did not have a large enough buffer to handle the ~1000 byte
>>path record. As you may know, the registry can hold very long paths,
>>but the DOS shell environment variables appear to be limited to 1023
>>bytes.
>>
>>
>
>Thanks for the tip! :-) The current buffer size in svnpath.exe is 1024
>bytes. I will increase it.
>
>
Instead, why don't you allocate it dynamically? Then something like this
won't happen again.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 1 20:44:59 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.