Re: svn commit: rev 7252 - trunk/tools/cvs2svn

kfogel@collab.net wrote:
> ...
> The log message of r7246 sort of implies that Max approved the change,
> but Max's comments above imply that he did not. So when committing
> outside your domain, the log message should say something like
> "Approved by Max Bowsher." (or by someone else appropriate to approve
> changes to the target domain).
>
> If you can't in all honesty write such a sentence, then it probably
> means the change shouldn't go in yet :-).

Ok, but I wasn't dissembling there. I didn't even know that Max was a
committer. I just wanted to give him credit for pointing out an
inconsistency in escape_shell_arg() in an earlier version of the patch.

- Russ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 1 04:11:10 2003