Re: svn commit: rev 7252 - trunk/tools/cvs2svn

"Max Bowsher" <maxb@ukf.net> writes:
> [snip: all PASS or XFAIL]

Note that one of them was FAIL on Windows -- the xbit test, number 6.
This is probably expected on Windows, but still it would be nice to
conditionalize it as XFAIL there. (Not Russell's fault, of course.)

> Hmm. Well, please don't commit outside your area even if the testsuite
> passes.

Or ask first, unless there's some sense in which the change is part of
your domain.

We don't have a hard and fast rule that says "A partial committer may
only commit in their designated directory." Sometimes a change in the
partial committer's domain has implications outside the usual
directory, and that's fine. Just use your judgement.

(It looks like these changes were not of that kind, anyway.)

> It failed for me on Cygwin, and began working again after reverting your
> revisions.
> Some of your changes were totally undiscussed. Most of the rest are still
> under discussion.

The log message of r7246 sort of implies that Max approved the change,
but Max's comments above imply that he did not. So when committing
outside your domain, the log message should say something like
"Approved by Max Bowsher." (or by someone else appropriate to approve
changes to the target domain).

If you can't in all honesty write such a sentence, then it probably
means the change shouldn't go in yet :-).

No big deal, just wait a little longer to verify that someone
qualified approves the commit next time. (The point of this system
isn't to prevent people from getting good work done, nor to provide
the the rest of us with a justification for blaming someone after the
fact -- so let's try to make sure it's doesn't get used that way!)

Best,
-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 30 20:53:33 2003