Re: Commit-mailer: very long message due to svn:eol-style change

Philip Martin <philip@codematters.co.uk> writes:

>> 3. Why does "svn:executable" show as changed in that last example?
>> I checked with "propget" and "hexdump": the value is two
>> characters, an asterisk followed by a newline, both before and
>> after the change.
>
> That looks like a bug, ra_local and ra_dav give different results:

Yes, ra_dav doesn't send prop "diffs".

Look at mod_dav_svn/update.c:374 close_helper(), there's a ### comment
about instructing the client to fetch all the props. Then in
add_node_props() and add_props() in libsvn_ra_dav/fetch.c the client
gets all the properties and reports them to the repos_diff editor.
The client's repos_diff editor expects diffs, and so simply reports
everything as changed.

We could
 a) Accept the current situation. The diff is not minimal but it does
    reflect the change.
 b) Modify ra_dav to generate property "diffs", I don't know where
    exactly we would do this.
 c) Modify the clients repos_diff editor to drop the bits that don't
    change.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org