[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] automatic properties

From: Branko Čibej <brane_at_xbc.nu>
Date: 2003-09-29 00:26:08 CEST

Philip Martin wrote:

>Martin Furter <mf@rola.ch> writes:
>>+ All matches found are parsed and the properties added to given path.
>>+ The format of the value is [propname[=value][;name[=val]]...]
>>+ @param path a filename
>>+ @param ctx the client context
>>+ @param pool apr memory pool
>>+ @param adm_access access baton, used when adding
>>+ @param editor editor, used when importing, must be NULL when adding
>>+ @param file_baton file baton for editor, used when importing
>>+ @param mimetype pointer for returning mimetype, used when importing
>>+ @param executable pointer for returning executable, used when importing
>>+ @return an svn_error_t or SVN_NO_ERROR when everything went OK
>The format of this comment is different from that of the others in the
>file. The others don't generally end with a list of parameters. The
>others use "@a name" when refering to parameters in the body of the
Except that we don't use that style in private headers. How's that for
confusion? :-)

>>Index: subversion/clients/cmdline/main.c
>>--- subversion/clients/cmdline/main.c (revision 7208)
>>+++ subversion/clients/cmdline/main.c (working copy)
>>@@ -124,6 +124,10 @@
>> "relocate via URL-rewriting"},
>> {"config-dir", svn_cl__config_dir_opt, 1,
>> "read user configuration files from directory ARG"},
>>+ {"auto-props", svn_cl__enable_autoprops_opt, 0,
>>+ "enable automatic properties"},
>>+ {"no-auto-props", svn_cl__disable_autoprops_opt, 0,
>>+ "disable automatic properties"},
>> {0, 0, 0, 0}
>> };
>>@@ -151,7 +155,8 @@
>> "Put files and directories under revision control, scheduling\n"
>> "them for addition to repository. They will be added in next commit.\n"
>> "usage: add PATH...\n",
>>- {svn_cl__targets_opt, 'N', 'q', svn_cl__config_dir_opt} },
>>+ {svn_cl__targets_opt, 'N', 'q', svn_cl__config_dir_opt,
>>+ svn_cl__enable_autoprops_opt, svn_cl__disable_autoprops_opt} },
>The command takes both options? Isn't one the default? We don't
>generally have both enable and disable options on the same command.
In this case you sort of need them, because you set the default in the
config file. You want to be able to override the default. (Hm, we really
should have a --no-config-dir options, too...)

Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 29 00:26:43 2003

This is an archived mail posted to the Subversion Dev mailing list.