Re: [PATCH] Tests

D.J. Heap wrote:

> Any objections to committing this?

+1, except for one tweak, see below.

Could you also take the time to submit an issue about the need to review
the libraries and insert calls to
svn_path_local_style/svn_path_internal_style wherever they're still
missing? Thanks.

[snip]

>+# On Windows, diffs still display / rather than \ in paths
>+ if svntest.main.windows == 1:
>+ name = name.replace('\\', '/')
>
>
Please user string.replace instead -- that is,

    name = string.replace(name, '\\', '/')

IIRC this will keep the tests compatible with Python 2.0. Greg, please
correct me if I'm wrong.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org