Re: Berkeley DB verbose error messages

Greg Stein <gstein@lyra.org> writes:

> On Thu, Sep 25, 2003 at 08:58:26PM +0200, Sander Striker wrote:
> >...
> > +/* Note that we 'abuse' the error prefix as a userdata field.
> > + The documentation suggests that this is safe:
> > +
> > + http://www.sleepycat.com/docs/api_c/env_set_errpfx.html
>
> Hmm? That says it doesn't try to copy the thing, but it doesn't say
> anything about *not* treating it as a char*. IOW, as far as we know, it
> might use it in some way and sticking an arbitrary pointer in there could
> be badness.

Yeah, I kinda think that we would be better off seeing if the
Sleepycat folks would (if technically trivial) consider making that
sucker a 'void *' and explaining that folks can pass in whatever they
want and get it back again via the callback. *Then* we apply your
patch. :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 25 23:33:29 2003