Re: svn commit: rev 7174 - in trunk/subversion: clients/cmdline include libsvn_client libsvn_ra_dav

Philip Martin <philip@codematters.co.uk> writes:

> > + apr_hash_set (creds_hash,
> > + SVN_CLIENT__AUTHFILE_ASCII_CERT_KEY,
> > + APR_HASH_KEY_STRING,
> > + svn_string_create (cert_info->ascii_cert, pool));
> > + apr_hash_set (creds_hash,
> > + SVN_CLIENT__AUTHFILE_FAILURES_KEY,
> > + APR_HASH_KEY_STRING,
> > + svn_string_createf(pool, "%d", creds->accepted_failures));
>
> If I understand this correctly it means that the SVN_AUTH_SSL_XXX
> values from svn_auth.h are stored in the auth cache on disk.

Yes, it's same thing that we do for 'simple' auth (username/password)
in libsvn_client/providers.c:

/* The keys that will be stored on disk */
#define SVN_CLIENT__AUTHFILE_USERNAME_KEY "username"
#define SVN_CLIENT__AUTHFILE_PASSWORD_KEY "password"
 
[...]

          apr_hash_set (creds_hash, SVN_CLIENT__AUTHFILE_USERNAME_KEY,
                        APR_HASH_KEY_STRING,
                        svn_string_create (username, pool));
          apr_hash_set (creds_hash, SVN_CLIENT__AUTHFILE_PASSWORD_KEY,
                        APR_HASH_KEY_STRING,
                        svn_string_create (password, pool));

> svn_auth.h should document this fact as the values now matter and
> changing them has consequences.

We already have these lines in libsvn_client/auth.c:

/* The keys that will be stored on disk */
#define SVN_CLIENT__AUTHFILE_ASCII_CERT_KEY "ascii_cert"
#define SVN_CLIENT__AUTHFILE_FAILURES_KEY "failures"

Perhaps all such macros should be moved into svn_auth.h instead?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 24 19:02:50 2003