[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: rev 7166 - trunk/subversion/libsvn_fs

From: Sander Striker <striker_at_apache.org>
Date: 2003-09-24 16:21:26 CEST

> From: cmpilato@localhost.localdomain
> [mailto:cmpilato@localhost.localdomain]On Behalf Of C.Michael Pilato
> Sent: Wednesday, September 24, 2003 4:05 PM

> Greg Stein <gstein@lyra.org> writes:
>
> > That said: I think the per-node pool is a poor idea, though I'm
> > hard-pressed to come up with a fix offhand.
>
> Yah. There doesn't seem to be an apr_pool_free()...

Correct. I have a very old dusty patch that implements apr_pfree...
I don't think the addition of apr_pfree to the API is going to be
received with a lot of cheering though.
 
>> I believe that pool creation is not nearly as cheap as a simple alloc.
>> Sander can correct me here, though. I've got a small tweak to improve the
>> pool handling a little bit:
>
> [...]
>
> > The net result is that you'll create N pools max, then start reusing
> > them.
>
> Yeah, that's a better plan. Will do.

Don't make N too large. Each pool reserves 8k of memory at a minimum.

[...]
> Right -- the real trick here was avoiding 4 or 5 BDB lookups per tree
> depth just to find a node. If someone wants to come along later and
> change the policy to start counting hit points or something, whatever
> -- not on my radar.

We could add it in the issue tracker as a post-1.0 task.

Sander

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 24 16:22:27 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.