On Wed, Sep 24, 2003 at 05:11:52AM -0700, Greg Stein wrote:
> On Tue, Sep 23, 2003 at 05:17:57PM -0500, cmpilato@tigris.org wrote:
> > Author: cmpilato
> > Date: Tue Sep 23 17:17:56 2003
> > New Revision: 7166
> >
> > Modified:
> > trunk/subversion/libsvn_fs/tree.c
> > Log:
> > Caching done (a little more closely to) right (I hope). Reviews, please?
>
> Heh. Saw your original commit and was going to suggest the looping index
> thing. I see you already got that feedback :-)
It might be interesting to instrument this code to see whether anothing
victimization strategy would be superior. At a glance, this looks like
an LRC policy; perhaps LRU might be better. It may be, though, that
the overhead of LRU might offset the gains in the cache-hit-ratio, or
that the effort involved in implementing LRU might be better spent doing
other optimizations.
--ben
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 24 15:37:41 2003