Re: Looking for auth. info. in the WC

On Wed, Sep 24, 2003 at 11:59:35AM +0100, Julian Foad wrote:
>...
> BTW, at first I assumed that svn_client__default_auth_dir got the new
> home-directory location, but it doesn't: it just tries the current and
> parent WC directories, very similar to __dir_if_wc. So I can also delete
> those two functions, which have no other use. (I searched.)

Excellent.

> I was unable to follow usage of this base_dir parameter down through
> svn_ra_dav__open, so I don't know for sure that it doesn't still try to
> use it. However, such usage is not documented for
> svn_client__open_ra_session, and it was always able to work with NULL
> (when the current directory is not a WC), so this should all be quite
> safe.

No. That parameter is necessary. When provided, it enables the RA layer to
fetch wcprop values. If you pass NULL, then you "hide" all wcprops from
the RA layer. That means that ra_dav will need to make a bunch of round
trips to the server to figure out the missing values. Quite awful.

Any change in this space will need to retain that parameter. It should
probably just point to the directory corresponding to the root of the RA
session.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org