cert caching touch-ups

sussman@tigris.org writes:

> Author: sussman
> Date: Mon Sep 22 11:51:57 2003
> New Revision: 7134
>
> Log:
> Finish issue #1330: New server-cert caching feature, implemented by
> Tobias Ringström <tobias@ringstrom.mine.nu>.

Tobias, just as a note, I made only a couple of tiny changes to your
patch:

* session.c (line 126) removed spurious semicolon typo.
  (server_ssl_callback): free dname and ascii_cert -after- we're done
  with save_creds. And delete the now incomplete cert-struct from the
  param hash, for paranoia.

* expanded comment in svn_auth.h (_ssl_server_prompt_func_t)

Overall, though, this patch was extremely clean and well-done.
Congrats!

I still have a stylistic nit to pick, though, which you can fix up on
your own time:

  Look at auth.c:513 and 557: why does the server_file_provider_baton
  need a cred_kind field at all? Why not just use the proper macro
  directly, since the provider funcs already know *exactly* what kind
  of credential they're dealing with?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 22 19:03:24 2003