Julian Foad <julianfoad@btopenworld.com> writes:
> This is the deepest I have dug into RA and WC adm stuff so far, so
> please tell me what I have missed and what I could do better. For
> one thing, I won't check it in with the "###...?" comment in it.
>
> I have a strong feeling that much of this logic is, or should be,
> common to subcommands like "diff", "export" and "copy" as well, and
> I would be grateful to be steered in that direction.
>
> My goal is to recognise not only "-rBASE" as being local, but any
> revision specifier that resolves to the cached text-base revision,
> such as dates and revision numbers that lie anywhere in the range
> from COMMITTED to BASE inclusive. And to do so in all situations
> that could benefit from it. But to start with, I decided to just
> implement "svn cat -rBASE". I don't think it is very important by
> itself, and am not especially bothered about checking it in if I can
> instead progress toward a more general implementation.
>
> Below the log message is a human-readable version of the patch,
> i.e. with intentation changes ignored and consequent word-wrapping
> edited out. Attached is the real patch, with which you can use your
> favourite space-insensitive diff tool.
The general approach looks good to me, and +1 on the incremental
philosophy (i.e., first solve 'svn cat -rBASE' with this minimal
change, then start generalizing to the broader change you describe
above). I think the easiest way to find the commonalities would be to
continue making small improvements like this, keeping an eye open for
repeated patterns.
Btw, I guess copy_stream() could just be a new public function
svn_stream_copy().
On a slightly different topic:
<confession>
This is totally gratuitous on my part, Julian, so let me start
off by saying that I know that, acknowledge it, and in my own
quaintly insincere way even apologize for it :-).
</confession>
After checking this in, would you consider grabbing one of the "---"
or pre-1.0 bugs? I had #1509 or #1245 specifically in mind. Most of
the current "---" items will end up being put in pre-1.0 milestones,
and it would be really great if we could focus on those before
post-1.0 bugs.
It's all about what scratches your itch, of course... I'm just trying
to make you itchy in a new place :-).
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 22 16:27:07 2003