Re: svn commit: rev 7100 - trunk/subversion/libsvn_fs

dlr@tigris.org writes:

> Author: dlr
> Date: Fri Sep 19 19:07:59 2003
> New Revision: 7100
>
> Modified:
> trunk/subversion/libsvn_fs/reps-strings.c
> Log:
> * subversion/libsvn_fs/reps-strings.c
> (rep_is_mutable): The only other use of strcmp in this file and the
> majority of its uses throughout the code base acknowledge that it
> has a numeric -- rather than boolean -- return type. Make it so in
> this function as well.

+1 on the change. But it has nothing to do with acknowledgement of
numeric returns. It's just visually easier to see the '==' or '!='
and think "strings are equal" or "strings are not equal", which is
exactly the opposite notion that using the numeric return value as a
boolean offers.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Sep 20 05:02:18 2003