[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Remove "temporary sanity checking" code from tweak_status

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2003-09-20 01:46:47 CEST

[[[
* subversion/libsvn_client/status.c
  (tweak_status) Remove "temporary sanity checking" code.
]]]

Index: subversion/libsvn_client/status.c
===================================================================
--- subversion/libsvn_client/status.c (revision 7075)
+++ subversion/libsvn_client/status.c (working copy)
@@ -43,7 +43,6 @@

 struct status_baton
 {
- apr_hash_t *hash; /* ### temporary */
   svn_boolean_t deleted_in_repos; /* target is deleted in repos */
   svn_wc_status_func_t real_status_func; /* real status function */
   void *real_status_baton; /* real status baton */
@@ -60,11 +59,6 @@
 {
   struct status_baton *sb = baton;

- /* ### temporary sanity checking code */
- assert (! apr_hash_get (sb->hash, path, APR_HASH_KEY_STRING));
- apr_hash_set (sb->hash, apr_pstrdup (apr_hash_pool_get (sb->hash), path),
- APR_HASH_KEY_STRING, (void *)1);
-
   /* If we know that the target was deleted in HEAD of the repository,
      we need to note that fact in all the status structures that come
      through here. */

Can I remove this? At a guess it appears to have been checking for unintended recursion. If it needs to stay, please could someone provide a proper descriptive comment for it.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Sep 20 01:46:31 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.