D.J. Heap wrote:
> e.huelsmann@gmx.net wrote:
>
>> Hi DJ,
>>
>> Thanks for looking into this some more.
>>
>>> From the comments found with the _tweak_paths function, I concluded
>>> that the
>>
>> function should go as soon as possible. So if you found occurrances
>> where it
>> is not needed anymore, then please remove it. Test your changes and
>> supply a
>> patch. I can't write these patches, since I don't have a Windows
>> machine to
>> run the test suite on.
>>
>> Reading your comments - and the test output log - I conclude that a
>> patch to
>> remove _tweak_paths from trans_tests.py and update_tests.py test 15.
>>
>> The problems you encounter with commit_tests.py I cannot comment on.
>>
>> Hope you can supply the patch for the first two tests at least.
>>
>> bye,
>>
>> Erik.
>>
>
> In order to completely remove the _tweak_paths methods scattered
> around, there is some code in svntest\main.py that will have to go,
> too, I think -- it checks for Windows and causes lots of paths to be
> generated with '/' rather than '\'. Also the greek_state tree might
> have to be tweaked for Windows, too, I'm not sure, and probably some
> of the Sandbox code.
That's right. I put the os.path overrides in main.py when SVN on Windows
was still printing slashes.
> Is that preferred to messing with the _tweak_paths methods? It seems
> cleaner to me, but I'm not sure how much work it will be. I should
> have time to work on it this weekend.
I agree. It shouldn't be that much work, either -- remove the os.path
tweaks, remove the _tweak_paths stuff and use os.path.normpath in the
path comparison functions in actions.py (and possibly elsewhere)
> Just to make sure, Subversion *is* moving towards outputting local
> path separators, right? I seem to recall a discussion about that and
> I think the consensus was that it should and is slowly getting
> there...but before I spend much time on that assumption, I rather get
> some confirmation...?
Yes, we're definitely moving towards accepting and printing paths in
local style. The appropriate conversion might still be missing in parts
of the code, but that can easily be fixed after the tests are modified.
--
Brane Čibej <brane_at_xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 16 22:27:54 2003