Re: [PATCH] svnadmin create --owner --group patch (new feature)

John Peacock wrote:

> Branko Čibej wrote:
>
>>> $ ./svnadmin create --owner nobody /tmp/test
>>> svn: Client error in parsing arguments
>>> svn: --owner and --group unavailable under Win32
>>
>>
>>
>> Heh, that's exactly the opposite of ignoring the option. :-) A warning
>> would be O.K., but an error is overdoing it in this case. It makes it
>> harder for people to write platform-independent scripts.
>>
>
> In general, I agree completely. In practice, though, svnadmin is not
> a likely target for scripting.

I can easily imagine a set of CGI scripts for repository management that
do that. In fact, I believe soch scriptshave already been written.

> And in this case, I thought that simply ignoring the option would be
> wrong, since it doesn't do what the user asked it to do _at all_ under
> Win32. I can change it to a warning, however. Can I use ASCII BEL
> control characters in the warning? ;~0

Yikes, please no.

>>
>>
>> In cases like this, I (we) prefer feature tests rather than platform
>> tests. That would involve adding checks for umask, setgid and setuid to
>> configure.in, then checking HAVE_UMASK, HAVE_SETUID and HAVE_SETGID.
>> There are (admittedly obscure) Unix-like systems that have some, but not
>> all of these functions. In any case, the world isn't divided between
>> Windows and Unix. :-)
>
> so that all of the Unix specific stuff doesn't exist for Win32...
>
> OK, if you are going to be that way about it ;~)
>
> I'll have to ask for help, then, since my configure.in-fu is very weak.

AC_CHECK_FUNCS(umask, setuid, setgid)

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org