Re: [PATCH] svnadmin create --owner --group patch (new feature)

Branko Čibej wrote:
> Your patch won't compile at all on Windows, because you're calling
> umask, setuid and setgid directly. You'll have to come up with a
> portable implementation of those functions (possibly in APR).

APR doesn't currently have anything comparable. Apache code itself calls all
three of those directly as well, though not within Win32 code presumably. I was
hoping there was a compatibility library which would stub out those calls as not
relevant to the Win32 security model.

Since the issue this patch was intended to solve, easy creation of appropriately
owned and chmod'd repositories, is only an issue under *nix-like O/S's, would
the appropriate solution to #ifdef the code out under Win32, or to try and
emulate the bits that map?

I believe that the only people complaining about the repository having the wrong
permissions/ownership are *nix users, hence it would make sense to only fully
support this on those systems.

John

-- 
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org