Re: Tests

Hi DJ,

Thanks for looking into this some more.

From the comments found with the _tweak_paths function, I concluded that the
function should go as soon as possible. So if you found occurrances where it
is not needed anymore, then please remove it. Test your changes and supply a
patch. I can't write these patches, since I don't have a Windows machine to
run the test suite on.

Reading your comments - and the test output log - I conclude that a patch to
remove _tweak_paths from trans_tests.py and update_tests.py test 15.

The problems you encounter with commit_tests.py I cannot comment on.

Hope you can supply the patch for the first two tests at least.

bye,

Erik.

> On Sun, 2003-09-07 at 15:04, D.J. Heap wrote:
> > It's being applied to expected_output. Here's the relevant test output
> > on Windows:
> >
> > EXPECTED STDOUT:
> > Sending working_copies/trans_tests-6/foo
> > Transmitting file data .
> > Committed revision 3.
> > ACTUAL STDOUT:
> > Sending working_copies\trans_tests-6\foo
> > Transmitting file data .
> > Committed revision 3.
> > EXCEPTION: SVNLineUnequal
> > FAIL: trans_tests.py 6: committing eol-style change forces text send
> >
> > DJ
> >
> >
>
>
> I've looked deeper into the three test failures I've been getting, and
> the trans and update tests are just because of the path separator.
>
> The trans_test can be fixed by fixing the _tweak_paths method which in
> that file is only used by that test -- it appears that Subversion has
> changed behavior slightly and is now sending back the local separator
> when it did not used to.
>
> The update test can be fixed by adding a _tweak_paths type method and
> using it in the test that fails.
>
> The question is, I guess, is this the way to handle it? Would a patch
> doing that be accepted, or does someone have a 'vision' for how this
> should be handled now that Subversion seems to be returning local
> separators more often (which is a good thing, IMO)?
>
> The commit test failure is slightly different -- the expected output
> seems to be the absolute path to the changed file, but all that is
> outputted is the filename (which is identical behavior as on Linux, as
> far as I can see); so, why is the expected output a full path on
> Windows and apparently not on Linux?
>
> I was hoping to find more evidence of the Windows filesystem problem to
> narrow in on it -- but these all appear to be simple test buglets from
> what I can see. At this point, I'm out of ideas to try on narrowing in
> on the 'access denied' problems...any suggestions?
>
> DJ
>
> PS: a complete log with all three test failures is at
> http://www.shadyvale.net/svn/tests.log if anyone wants to look at it.
> They are commit test 22, update test 15, and trans test 6.
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>

-- 
+++ GMX - die erste Adresse für Mail, Message, More! +++
Getestet von Stiftung Warentest: GMX FreeMail (GUT), GMX ProMail (GUT)
(Heft 9/03 - 23 e-mail-Tarife: 6 gut, 12 befriedigend, 5 ausreichend)
Jetzt selbst kostenlos testen: http://www.gmx.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org