Re: [PATCH] Fix issue #1330: accept server cert permanently

Tobias Ringström <tobias@ringstrom.mine.nu> writes:

> Index: subversion/clients/cmdline/prompt.c
> ===================================================================
> --- subversion/clients/cmdline/prompt.c (revision 7042)
> +++ subversion/clients/cmdline/prompt.c (working copy)
> @@ -24,6 +24,8 @@
>
> #include <apr_lib.h>
>
> +#include <ne_ssl.h>

You are putting neon code into the client. One problem: if neon is
not available Subversion will build without libsvn_ra_dav and your
patch breaks that. It appears to be only this one file that is
affected.

Perhaps the neon code in the client should be conditional on something
like SVN_HAVE_NEON. You would need to create SVN_HAVE_NEON, but the
configure script already handles SVN_LIBSVN_CLIENT_LINKS_RA_DAV so
most of the work has been done.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org