Re: [PATCH] Change warning to exception in testcase.py

=?UTF-8?B?QnJhbmtvIMSMaWJlag==?= <brane@xbc.nu> writes:
> B. W. Fitzpatrick wrote:
>
> >I'm sending this here for review before applying because I know it's a
> >bit of a militant move, but it will sure keep people from returning a
> >status code from their tests. :)
> >
> >After applying this patch (or a variant of it), we can officially close
> >Issue #1192, thanks to Erik Hî…¦smann for doing most of the work to
> >finally finish this off.
> >
> >
> If the tests pass with this change, then it's obviously fine.
>
> >+
> >+class SVNTestStatusCodeError(Exception):
> >+ 'Test driver returned a status code.'
> >+ pass
> >+
> >+
> > class _Predicate:
> > """A general-purpose predicate that encapsulates a test case (function),
> > a condition for its execution and a set of display properties for test
> >@@ -92,13 +98,15 @@
> > print self.pred.skip_text(),
> > else:
> > try:
> >- # FIXME: Remove this return code check after all tests
> >- # have # been converted to throw exceptions instead of
> >- # returning error codes.
> > rc = apply(self.pred.func, args)
> > if rc is not None:
> > error = rc
> >- print 'WARNING: Test driver returned a status code'
> >+ raise SVNTestStatusCodeError
> >+ except SVNTestStatusCodeError, ex:
> >+ print "STYLE ERROR in",
> >+ self._print_name()
> >+ print ex.__doc__
> >+ sys.exit(255)
> >
> >
>
> Why on earth do you need a new exception class and handler? instead of
> raising this exception and catching it in the same try block, just print
> an error message and exit, right?

Not quite. The test is applied in the try block, and if I exit in the
try block, it's caught below in the 'except SystemExit' block and it
makes for a not-so-nice exit, so I've gotta do something other than just
exit.... any suggestions?

-Fitz

--
Brian W. Fitzpatrick    <fitz_at_red-bean.com>   http://www.red-bean.com/fitz/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org