Re: svn commit: rev 7004 - branches/svnserve-thread-pools/subversion/svnserve

mark benedetto king <mbk@lowlatency.com> writes:

> I'm not offended (proud to be in such good company, even), but I am
> wondering what mistakes you saw.
>
> Error handling aside (and some minor optimizations removed), things are
> essentially:
>
> wait(cond, mutex):
> # section 1:
> # wait for pending signals to be delivered
> while 1:
> acquire(cond->mutex)
> if !cond->num_undelivered:
> break
> release(cond->mutex)

That loop could be waiting for other threads to make progress and yet
it doesn't block, instead it relies on release/acquire being
sufficient to allow the other threads to proceed. While it probably
works, it's not particularly elegant.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org