Re: [PATCH] svnadmin hotcopy, hot-backup.py race conditions fix

Vladimir Berezniker wrote:
>
> Here is the hot copy patch. The patch implements svnadmin hotcopy
> command with optional --archive-logs flag. If flag is specified, after
> the copying is complete, unused *copied* log files are deleted from the
> source repository.

1. Ah... throughout your description and log message and patch you use the word "archive" to mean "delete", but actually it means "save" or "store". It is quite likely that you got this from the "svnadmin archive" subcommand, but unfortunately that subcommand was very badly named and it has recently been renamed to the much better "svnadmin list-unused-dblogs".

2. The log message should be less than 80 columns wide, like the source code.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 9 01:58:17 2003