Re: [PATCH] ra->get_commit_editor API cleanup

I think your patch may have been word-wrapped. If you're inserting or
pasting a patch into Evolution, you should change the formatting from
"Normal" to "Preformat" first.

On Sat, 2003-09-06 at 01:34, Chia-liang Kao wrote:
+ * When a filesystem commit succeeds, an instance of this is invoked on

This should probably just be "When a commit succeeds," now that it's not
specific to svn_repos commits.

+/* get the commit_baton to be used in couple with commit_callback. */
+/* the commit_callback function for storing svn_client_commit_info_t
+ pointed by commit_baton. If the commit_info supplied by get_baton
+ points to NULL after close_edit, it means the commit is a no-op.
+*/

Capitalize, please.

+ SVN_ERR (svn_ra_svn_read_tuple(ccb->conn, ccb->pool, "r(?c)(?c)",
+ return ccb->callback (new_rev, committed_date, committed_author,

ra_svn doesn't put spaces before the open paren of a function call;
please remain consistent.

+ SVN_ERR ( cc->callback (new_rev, committed_date, committed_author,
+ cc->callback_baton));

Likewise for ra_dav code. (Greg minds think alike, at least on this
tiny point of style.) Although the space after the open paren of an
SVN_ERR appears to be de rigeur in that module, unlike ra_svn.

Otherwise, looks good. If you fix these problems and resubmit, I'll
commit the change, barring objections from others.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Sep 6 06:16:05 2003